Agree with TQ.
If your PhD work is based on some maths equations then make sure you can justify using them, what common alternatives you are not using and some simple derivations. What approximations are being applied. That sort of thing.
You might well be asked to show full derivations but there is no harm in saying sorry I cant do that.

The viva is there for you to demonstrate you have done enough work to get a PhD and that you personally performed the work.

Your supervisor sounds like a bit of a dick.

The gap shouldn't be a problem. I wouldn't have thought that you would need a Masters either unless all the positions you want are being targetted by those who have one.
Also, there is no reason to wait until next year.
Start looking and applying now.

TQ, am I right in thinking that the journal has a high impact factor?
If so, I can absolutely guarantee they will be inundated with submissions from every Tom, Dick and Harry who all believe their work is worthy of a Nobel Prize and should be published yesterday.
That might explain the delay. I have known people to wait over a year to get articles in the "top" journals.

All of that will depend on the university. You should ask this question of your supervisor directly. They are all different.

Zena85, did you ensure you had some good referees before you initiated your formal complaint?
If you didn't, this could get quite difficult for you.

Knowing when to quit is an important skill.
Maybe the timing is wrong for you, You can always try again later in life.

Glad to be of help.
When things go wrong it can be difficult to avoid getting sidetracked by stuff like this.
You have the right idea of taking a break to re-think how to proceed.
Good luck with it.

Your core issue here is your lack of progress in your PhD but instead of focussing purely on fixing this you are obsessing over what your colleague is doing. This has absolutely nothing to do with you whatsoever and I would back away from this immediately before it starts to affect your work and your health. I am sensing some jealousy and some resentment in your post. Really this is neither appropriate nor helpful to you. If your PhD was working fine I am pretty sure you wouldn't care how your colleague was behaving.

Leave your colleague alone. You have more important issues to deal with. If working weekends isn't helping, talk to your supervisor. That is what they are there for and this is when you find out how good they really are. Once your PhD starts working again you'll find your colleague's behaviour won't matter to you.

You should ignore your supervisors opinions now. This nonsense about 10 years without a large income is absolute horseshit. How on earth is he able to predict your future with such certainty? How can someone who has presumably never worked outside academia possibly know whether you'll be overqualified with a Phd? It's laughable nonsense.
Focus on your PhD, keep working hard and like virtually every other student out there you'll get your PhD certificate and be able to move on.
This guy sounds like a grade A arsehole who is deliberately trying to force you out because if you fail it will look bad on his record.
He also doesn't want to pull the plug, he wants you to do that. Stick to your guns. Let him pull the trigger. I bet he won't.

Technically your primary supervisor has not told you how many hours to dedicate to continued data collection.
There is nothing whatsoever to stop you allocating 5-10 hours per week collecting and the remainder of your week analysing what data you already have. Only after completing your current analysis do you attempt to analyse the new data (if and only if there is time). I would even tell the guy that you are prepared to continue analysing the new data after the PhD funding ends. This should keep him at bay.

Cut off your primary supervisor as much as possible, working from home if needed. Let him chase you for progress updates etc and be vague when responding. At this stage you should need this person much anyway.

This is a pretty passive aggressive way to play things but it should work quite well.

Why is age a factor for you at only 40?
As for what you should do?
It's difficult to advise but personally I would be looking out for what I wanted and not what anyone else (even a supportive newly tenured professor) wanted. You owe nothing to anyone but yourself.

Hope I'm not too late with some advice TQ.
When it comes to working or doing business with someone ALWAYS trust your gut.
If you weren't feeling time pressured to sort something out would you walk away?
Personally if I have an off feeling about anyone I would always walk from the deal.
It's all about people in my experience. If you don't have that up front it'll be trouble in the end.

You don't have to justify your life choices to anyone but yourself.
The people on long hours and low pay would be better off focussing on their own lives rather than trying to make you feel bad.

It's good to have an exit plan when you walk into any job regardless of qualifications or experience.

As for their lack of success applying for jobs, it could be down to a number of things. I wouldn't necessarily accept that it's over-qualification and/or lack of real world experience unless they are being told this explicitly. People do use these two things as a ready excuse. I'm not saying that this is the case for your colleagues but the majority of people I have met throughout my career who struggle to get work, struggle for very good reasons unrelated to their ability.

This real world experience thing is interesting. Employers will be looking for academically minded people who understand time budgets, cost awareness and have an understanding that if you are trying to create things like a new chocolate bar recipe, you don't look at reactions which use Rhodium catalysts etc.
I have seen some large companies insist that you have at least one or two postdocs before they'll hire a PhD researcher so it's not a clear picture.

My advice to these colleagues would be to look at the job specs and work out which things they are missing. Then actively figure out how to acquire those things. It's probably not a good thing to wait until the end of your academic career to work these things out.

Ha ha. Yep that sounds familiar.
Academics will or should have a host of softskills which are highly sought after in industry.
I wouldn't worry too much about it to be honest.
Sounds like your postdocs have been ground down a bit. Not surprised by that. It's not a great environment from what I have experienced.